Skip to content

Conversation

@VeraZab
Copy link
Contributor

@VeraZab VeraZab commented Apr 9, 2019

closes: #717

@VeraZab VeraZab changed the title Determine which arrows to show on which folds Add ability to reorder folds Apr 9, 2019
@VeraZab VeraZab marked this pull request as ready for review April 9, 2019 22:07
@VeraZab
Copy link
Contributor Author

VeraZab commented Apr 9, 2019

@nicolaskruchten I think this is what we want would you check please ✨
I didn't add it to other accordions, but this easily could be extended to them

@VeraZab
Copy link
Contributor Author

VeraZab commented Apr 9, 2019

@dmt0 I think this is ready for code review as well

@VeraZab
Copy link
Contributor Author

VeraZab commented Apr 10, 2019

adjusted styles
Screen Shot 2019-04-10 at 11 02 25 AM

@VeraZab
Copy link
Contributor Author

VeraZab commented Apr 10, 2019

so I've added the ability to reorder: images, shapes, annotations on top of traces

for transforms, I wasn't sure about the array to reorder (it changes based on the transform applied, and I'm not sure of the side effects) so I didn't do it here.

for rangeselector buttons, the path to get to the array to reorder is a bit less straight forward. I could perhaps use the nested property function of plotly.js. but didn't do it here.

just picked the low hanging fruit. let me know if that's ok @nicolaskruchten

@dmt0
Copy link
Contributor

dmt0 commented Apr 10, 2019

💃 !

@nicolaskruchten
Copy link
Contributor

✨ although I don't love the "you can't click here" cursor on the greyed out arrows... I'd just leave it as a normal non-link cursor.

@VeraZab
Copy link
Contributor Author

VeraZab commented Apr 10, 2019

although I don't love the "you can't click here" cursor on the greyed out arrows

yeah, agree, removed!

@VeraZab VeraZab merged commit e2fb6a1 into master Apr 10, 2019
@VeraZab VeraZab deleted the moveable-folds branch April 10, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reorderable traces

4 participants